Always request and use fetched edit token. #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed now unused persisting of edit tokens to keychain.
joewalsh
suggested changes
Jan 6, 2017
| upload(); | ||
| EditTokenFetcher *tokenFetcher = (EditTokenFetcher *)sender; | ||
|
|
||
| (void)[[WikiTextSectionUploader alloc] initAndUploadWikiText:tokenFetcher.wikiText |
There was a problem hiding this comment.
seems like the WikiTextSectionUploader (and the EditTokenFetcher initialized on line 675) should be assigned to properties and retained. Having unowned objects like this could lead to them being dealloc'd and not actually completing the fetch.
There was a problem hiding this comment.
Ah, good catch. Want me to fix that as part of this PR?
There was a problem hiding this comment.
Yeah, would be good to fix it in this PR
joewalsh
approved these changes
Jan 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T153106
Also removed now unused persisting of edit tokens to keychain.