Fix for min face area not being proportional. #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montehurd
commented
Apr 27, 2017
| CGFloat imageArea = image.size.width * image.size.height; | ||
| CGFloat faceProportionOfImage = faceArea / MAX(imageArea, 0.0000001); | ||
| // Reminder: "0.0178" of the area of a 640x640 image would be roughly an 85x85 area. | ||
| BOOL faceIsBigEnough = (faceProportionOfImage >= 0.0178); |
There was a problem hiding this comment.
The new proportional value of 0.0178 was chosen by simply increasing it until the test passed.
montehurd
force-pushed
the
bug/tiny-thumb-face-detection/T163965
branch
from
679e4a7
to
20589d1
Compare
montehurd
force-pushed
the
bug/tiny-thumb-face-detection/T163965
branch
from
20589d1
to
0679d8c
Compare
montehurd
commented
Apr 27, 2017
| CGFloat imageArea = image.size.width * image.size.height; | ||
| CGFloat faceProportionOfImage = faceArea / MAX(imageArea, 0.0000001); | ||
| // Reminder: "0.0178" of the area of a 640x640 image would be roughly 85x85. | ||
| isFaceBigEnough = (faceProportionOfImage >= 0.0178); |
There was a problem hiding this comment.
0.0178 was roughly the smallest value at which our minimum size face test passed. Proportionally it seemed about right.
joewalsh
approved these changes
Apr 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The face area check was a bit off. The face bounds are unit values which need to be denormalized to image size to get the face's actual area in terms of the image's area. Then we can divide the actual face area by the image area to get a resolution-independent proportion.
Before
After