Make TOC text direction always match article text direction. #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montehurd
force-pushed
the
regression/rtl-toc/T149066
branch
from
6e4af08
to
e6bfffb
Compare
montehurd
changed the title
montehurd
changed the title
|
Oops forgot to test when device lang is RTL and you load a LTR article... |
…ches. This commit fixes both mismatch possibilies: - device RTL with LTR article - device LTR with RTL article
montehurd
changed the title
montehurd
commented
May 2, 2017
| @@ -32,6 +32,8 @@ open class WMFTableOfContentsViewController: UIViewController, | |||
| WMFTableOfContentsAnimatorDelegate { | |||
|
|
|||
| let tableOfContentsFunnel: ToCInteractionFunnel | |||
|
|
|||
| let semanticContentAttribute: UISemanticContentAttribute | |||
There was a problem hiding this comment.
Considered naming this semanticContentAttributeOverride... any naming preference?
There was a problem hiding this comment.
actually I like semanticContentAttributeOverride
|
retest this please |
amrox
approved these changes
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T149066
When device lang is LTR...
Before
The TOC was still LTR when the article was RTL:
After
The TOC is RTL when the article is RTL:
