Test for beta changes to mobileview html output. #1428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 39cafb8.
|
BearND had some suggestions I'd like to look into before we consider merging this. |
|
Closing this until I have time to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T165207
This is to try to give us early warning for changes to mobileview section html output which have been staged to the beta cluster. That way we can examine such changes as soon as they land on beta instead of when they land in production. Hopefully we can avoid issues like this: https://phabricator.wikimedia.org/T165115
I added a pretty giant comment to the test failure message. Open to moving this to comments in the test itself if anyone prefers.I moved it :)