Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure we don't deselect the selected tabBarItem when presenting alerts on iPad #2090

Closed
wants to merge 10 commits into from

Conversation

natharateh
Copy link
Contributor

@natharateh natharateh commented Mar 2, 2018

@natharateh natharateh added the WIP label Mar 2, 2018
@natharateh
Copy link
Contributor Author

Instead of asking for the view of the selected tab bar item and setting passthroughViews to include that view, I can set passthroughViews to include the entire tab bar. However, if I do that, after dismissing the alert (via tabBarController:(UITabBarController *)tabBarController didSelectViewController:(UIViewController *)viewController in WMFAppViewController) the view that was presenting the alert will not know that the alert was dismissed and as a result, will not update the tintColor of its buttons.

@montehurd
Copy link
Contributor

I added quick note to the ticket: https://phabricator.wikimedia.org/T187515#4024679

@natharateh natharateh closed this Mar 5, 2018
@montehurd
Copy link
Contributor

Looks like setting

tabBar.tabBar.tintAdjustmentMode = UIViewTintAdjustmentModeNormal;

on the line before

self.rootTabBarController = tabBar;

in loadMainUI fixes it

screen shot 2018-03-05 at 11 19 47 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants