Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second set of RTL audit fixes #2515

Merged
merged 7 commits into from Jul 30, 2018
Merged

Second set of RTL audit fixes #2515

merged 7 commits into from Jul 30, 2018

Commits on Jul 28, 2018

  1. use query parameter to get gallery image description languages 

    this means we'll get back an array of descriptions - keys are lang codes, values are descriptions for respective lang codes
    @montehurd
    montehurd committed Jul 28, 2018
    Copy the full SHA
    f8ad5bf View commit details
    Browse the repository at this point in the history

  2. add imageDescriptionIsRTL property to MWKImageInfo

    @montehurd
    montehurd committed Jul 28, 2018
    Copy the full SHA
    8f1cae2 View commit details
    Browse the repository at this point in the history

  3. update MWKImageInfo response serializer to extract appropriate descri… 

    …ption

takes the user's preferred languages into account
    @montehurd
    montehurd committed Jul 28, 2018
    Copy the full SHA
    9fdb1aa View commit details
    Browse the repository at this point in the history

  4. use imageDescriptionIsRTL with other MWKImageInfo inits

    @montehurd
    montehurd committed Jul 28, 2018
    Copy the full SHA
    94bfafc View commit details
    Browse the repository at this point in the history

  5. use imageDescriptionIsRTL to control gallery label description `tex… 

    …tAlignment`
    @montehurd
    montehurd committed Jul 28, 2018
    Copy the full SHA
    89edf1f View commit details
    Browse the repository at this point in the history

  6. fix test

    @montehurd
    montehurd committed Jul 28, 2018
    Copy the full SHA
    7f0911e View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2018

  1. Merge branch 'develop' into fix/rtl-issues/T199569-2

    @joewalsh
    joewalsh committed Jul 30, 2018
    Copy the full SHA
    ff38b5b View commit details
    Browse the repository at this point in the history