Article language tweaks for Article "Read More" #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Josh's comments on the ticket.
| public let titleText: String = localizedStringForKeyFallingBackOnEnglish("article-read-more-title") | ||
| let site:MWKSite | ||
| init(site: MWKSite) { | ||
| self.site = site |
There was a problem hiding this comment.
is calling super.init() optional in swift?
There was a problem hiding this comment.
Fixed. Interestingly in Swift instance vars need to be set before super init... http://stackoverflow.com/a/24150540
There was a problem hiding this comment.
yeah - anything that is a let needs to be set before you call init - since that is a constant (can't change later). for instance you can see the delegate ivar in the toc view controller is just a var. so it doesn't need to be set.
added 2 commits
November 18, 2015 09:37
|
👍 |
|
👍 restarted the build, which looks to be failing due to timeout issues. |
bgerstle
added a commit
that referenced
this pull request
Nov 18, 2015
Article language tweaks for Article "Read More"
bgerstle
added a commit
that referenced
this pull request
Dec 28, 2015
Article language tweaks for Article "Read More"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hebrew version of "food" article:
Before:
After:
