Fix clear formatting on headers #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joewalsh
added
the
Dependent PR
montehurd
approved these changes
Mar 26, 2019
joewalsh
removed
the
Dependent PR
|
A couple of things I'm noticing - Article "Diamonds Are Forever (novel)" - the first paragraph has remove markup disabled. Maybe related to that template embedded earlier in the line but formatting after the template should be removable.
I see some characters removed when removing formatting. I tested on italics, bold, and links - |
|
@tonisevener the first issue I'm seeing on develop as well so I can file that as a follow-on issue. The second issue is definitely a regression caused by this PR and I've pushed a fix |
|
@tonisevener it looks like the first issue was caused by the template changes, so I reverted that and made disabling the clear formatting button in templates a follow on task: https://phabricator.wikimedia.org/T219321 |
tonisevener
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in weekly planning, this PR makes the clear formatting butting clear header markup when any part of a header is selected