Initial talk page work #3066
Initial talk page work #3066
Conversation
|
Not much to see on the UI side of things but please let me know if I'm off track with any of this so far. I will be switching to integrating the talk page endpoint & list screen UI now. |
| </entity> | ||
| <entity name="TalkPageDiscussionItem" representedClassName="TalkPageDiscussionItem" syncable="YES" codeGenerationType="class"> | ||
| <attribute name="depth" attributeType="Integer 16" defaultValueString="0" usesScalarValueType="YES" syncable="YES"/> | ||
| <attribute name="text" attributeType="String" syncable="YES"/> |
There was a problem hiding this comment.
You could also keep the text in a file and store a reference as an attribute on TalkPageDiscussionItem, in some cases there could be a lot of text
There was a problem hiding this comment.
Good to know, I was unsure if it would be overkill so I didn't want to tackle it initially - I'll look into that after I flesh out the UI more.
There was a problem hiding this comment.
FYI planning to do this separately as a part of https://phabricator.wikimedia.org/T222721.
| } | ||
|
|
||
| //first delete old discussions | ||
| //todo: is there a better way to do this? simply reassigning discussions is not enough |
There was a problem hiding this comment.
If I'm understanding this correctly, you could compare your existing discussions with the discussions that are coming from the server and figure out what changed (what was deleted, what was added, what was updated) and then process those specific changes - we do something like that for reading lists -
specifically here's where the updates happen -
There was a problem hiding this comment.
Oh yeah that would be better. Right now I'm just throwing out all discussions and recreating them if the revision ID has changed. The question was more around delete rules - the old discussions still hang around in the DB even after I reassign the talk page to a new set of discussions. This was a note to look into a way to have that delete cascade on that assignment without explicitly looping through and deleting them all. But agreed being more selective about what I delete would be a better way to go.
… remove dependence on MWKDataStore
Track read status of talk page topics, Core Data thread safety fixes
talk page - added superscript and subscript handling
…is updated whenever namespace is updated
|
Not feature complete but I think this is far enough along to review for merging into develop. |
[Talk Pages Dev] Support list items in html-to-attributed string code
User talk is not showing in History
No description provided.