talk page - CoreData housekeeping #3134
Conversation
Delete talk pages > 50
| @@ -124,7 +135,7 @@ extension NSManagedObjectContext { | |||
| func removeUnlinkedTalkPageTopicContent() throws { | |||
| let request: NSFetchRequest<TalkPageTopicContent> = TalkPageTopicContent.fetchRequest() | |||
| request.predicate = NSPredicate(format: "topics.@count == 0") | |||
| let results = try request.execute() | |||
| let results = try fetch(request) | |||
There was a problem hiding this comment.
before this change I was getting a "Cannot fetch without an NSManagedObjectContext in scope}" console error and TalkPageTopicContent objects were not clearing out in housekeeping.
| @@ -70,6 +70,7 @@ | |||
| </fetchIndex> | |||
| </entity> | |||
| <entity name="TalkPage" representedClassName="TalkPage" syncable="YES" codeGenerationType="class"> | |||
| <attribute name="dateAccessed" attributeType="Date" defaultDateTimeInterval="582233760" usesScalarValueType="NO" syncable="YES"/> | |||
There was a problem hiding this comment.
This defaults to the date/time I created the attribute (06/14/2019), let me know if there's a better one.
|
|
||
| let oldTalkPages = try moc.fetch(request) | ||
| for talkPage in oldTalkPages { | ||
| moc.delete(talkPage) |
There was a problem hiding this comment.
might be a good use case for a batch delete https://developer.apple.com/library/archive/featuredarticles/CoreData_Batch_Guide/BatchDeletes/BatchDeletes.html
| @@ -20,14 +20,23 @@ extension NSManagedObjectContext { | |||
| fetchRequest.fetchLimit = 1 | |||
| fetchRequest.predicate = NSPredicate(format: "key == %@", databaseKey) | |||
|
|
|||
| return try fetch(fetchRequest).first | |||
| let talkPage = try fetch(fetchRequest).first | |||
| talkPage?.dateAccessed = Date() | |||
There was a problem hiding this comment.
I'm a bit concerned that the method for fetching a talk page also mutates it and saves the context - could I move this into a separate function that's explicitly called when the user views the talk page or is there some other consideration that I'm missing?
There was a problem hiding this comment.
I think I misread "accessed" to mean "viewed by the user" - is the intent to have this property updated anytime the object is accessed even by non-user task?
There was a problem hiding this comment.
@joewalsh true, agreed, non-user task shouldn't update this in my opinion. I really meant viewed by the user & wanted to keep track of what talk pages they seem to be interested in lately and update that date. Then later I sort by that date so we are deleting talk pages that they don't seem to be visiting anymore. To keep it simpler we could probably only timestamp this after it's fetched in the view controller so we know it was instigated by the user.
There was a problem hiding this comment.
@tonisevener makes sense. I pushed a change, but feel free to alter or revert if you had other ideas
|
Updated with PR feedback -
|
Delete talk pages > 50