Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content offset at about screen #3212

Merged
merged 3 commits into from Sep 3, 2019

Conversation

akarataev
Copy link
Contributor

@montehurd
Copy link
Contributor

montehurd commented Aug 26, 2019

Thanks for the PR! 😀

There's a weird offset issue (bug?) with iOS 12 that we've had to work around in the past, but in this particular case there may be a simpler fix using this special top fragment.

@montehurd
Copy link
Contributor

Any time to double-check the possible fix I mentioned? 🤔

@tonisevener
Copy link
Collaborator

@akarataev also just a heads up - our develop branch has been updated for Xcode 11 beta 7, in case you start seeing build errors

@akarataev
Copy link
Contributor Author

akarataev commented Aug 29, 2019

@montehurd hello,

thanks for the hint, I'll check it such soon as possible.

@akarataev
Copy link
Contributor Author

Hello @montehurd, @tonisevener

I've updated the branch. New solution is based on iOS12yOffsetHack and JavaScript.
I couldn’t make a result with top fragment, because it also has an incorrect offset.

@montehurd
Copy link
Contributor

[wv loadHTMLFromAssetsFile:kWMFAboutHTMLFile scrolledToFragment:@"#top"];

^ this change to L134 seems to work on my end... though I haven't tested all scenarios🤞. Is it give you an incorrect offset?

@akarataev
Copy link
Contributor Author

Oh, you right, it works fine. It strange because <a href="#top"> under WebView works incorrect.
Thanks for good point and patience. I've updated branch.

@joewalsh joewalsh merged commit ef970ed into wikimedia:develop Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants