New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix content offset at about screen #3212
Conversation
Update develop branch
Thanks for the PR! 😀 There's a weird offset issue (bug?) with iOS 12 that we've had to work around in the past, but in this particular case there may be a simpler fix using this special |
Any time to double-check the possible fix I mentioned? 🤔 |
@akarataev also just a heads up - our develop branch has been updated for Xcode 11 beta 7, in case you start seeing build errors |
@montehurd hello, thanks for the hint, I'll check it such soon as possible. |
d82cc35
to
883e82c
Compare
Hello @montehurd, @tonisevener I've updated the branch. New solution is based on |
^ this change to L134 seems to work on my end... though I haven't tested all scenarios🤞. Is it give you an incorrect offset? |
28cb323
to
98f1dac
Compare
Oh, you right, it works fine. It strange because |
https://phabricator.wikimedia.org/T229528
Screenshots