Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2nd missing completion handler check #3510

Merged
merged 1 commit into from Apr 1, 2020

Conversation

tonisevener
Copy link
Collaborator

Missed this one last time. Fixes crash at these steps:

  1. Load article
  2. Force press an external link
  3. App crashes

Feels a little weird that this does nothing now but this is how it acts in 6.5.1. Might be worth bringing up to the others for better handling.

@tonisevener tonisevener added this to the 6.6 milestone Apr 1, 2020
@joewalsh joewalsh merged commit dc63c72 into develop Apr 1, 2020
@joewalsh joewalsh deleted the bug/external-context-menu-crash branch April 1, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants