Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article as a Living Document feature - Modal #3683

Merged
merged 123 commits into from Oct 19, 2020
Merged

Article as a Living Document feature - Modal #3683

merged 123 commits into from Oct 19, 2020

Conversation

tonisevener
Copy link
Collaborator

@tonisevener tonisevener commented Sep 10, 2020

Fixes Phabricator ticket:
https://phabricator.wikimedia.org/T258209

Remaining Tasks

In a somewhat particular order, but not super rigid on that.

Modal (https://phabricator.wikimedia.org/T258209)

  • (MC) UI - add footer "View full article history" button
  • (TS) UI - Add Thank / View Changes / View Discussion button assets (see https://phabricator.wikimedia.org/T258209#6468770 for assets)
  • (TS) Layout - polish all spacing and font sizes (including iPad) (see https://phabricator.wikimedia.org/T258209#6468770 for font sizes)
  • (MC) Layout - Try to shrink down the timeline dots & squiggle, it feels too large
  • (MC) Layout - if rotate to landscape, scroll down, rotate back to portrait, and scroll all the way up to the top of the VC we the top 100 or 200 points of the VC is hidden behind the underbarheaderview
  • (MC) Layout - Fix header issues (seems it doesn't play nice with the iOS13-style pageSheet presentation
  • (TS) Layout - Optimize scrolling performance (consider having all side-scrolling cells be the same size to limit sizing layout passes) - they're the same size now, but more performance testing / tweaking can be done.
  • (DM) Data - Format edit counts so we have commas (was previously seeing a crash when attempting this, need to look into that).
  • Data - Section headers should probably have the == signs stripped.
  • (TS) UI - Add theming
  • (MC) Other - Tapping snippet links handling/flow
  • (MC) Other - Tapping User Name handling/flow (already pops to Safari but we should show in-app web view controller)
  • (MC) Other - View changes button handling/flow
  • (MC) Other - View discussion button handling/flow
  • (MC) UI - "x small changes" needs to be a link (which I assume kicks you out to Page History at those revisions). Also currently if you tap that text it becomes an editable text field, and we need to fix that behavior as well.

Base automatically changed from T258208-content-insert to main October 16, 2020 22:41
@tonisevener
Copy link
Collaborator Author

@mcleinman All your changes look good to me! Thanks so much for your help on this! 🙏

Copy link
Contributor

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonisevener and your changes look great to me! I think we're ready to merge!

@mcleinman mcleinman merged commit 218acf0 into main Oct 19, 2020
@mcleinman mcleinman deleted the T258208 branch October 19, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants