New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AaaLD - article content interstitial design polish #3744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tweaks overall. A few questions/comments.
When playing with text sizes, I found another bug. Feel free to fix it here, or spin it out into its own Phab ticket (and assign to me if you want - it's likely a bug I didn't find before, almost definitely not something you introduced).
- The AaaLD modal uses the device's text size. At the largest (non-accessibility) text size and the smallest text size, open the AaaLD modal. (I didn't check on large accessibility sizes.)
- Note that the scrollview is scrolled all the way to the bottom - instead of the top, as expected. Also, the navbar underbar view is showing.
- I'm unclear if this is a bug in the navbar, the auto-scrolling (which shouldn't be happening in this situation), or something else. But I'd be happy to dig in if you'd like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great, thanks!
Phab ticket for this bug: https://phabricator.wikimedia.org/T266621 |
Fixes Phabricator ticket:
https://phabricator.wikimedia.org/T265666
https://phabricator.wikimedia.org/T265669
Notes