Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve POTD size in explore feed #3844

Merged
merged 3 commits into from Feb 2, 2021
Merged

Improve POTD size in explore feed #3844

merged 3 commits into from Feb 2, 2021

Conversation

tonisevener
Copy link
Collaborator

Fixes Phabricator ticket: https://phabricator.wikimedia.org/T164642

Notes

Test Steps

  1. Map locally the https://en.wikipedia.org/api/rest_v1/feed/featured/2021/xx/xx endpoint (depending on which day you're testing) with the response at https://en.wikipedia.org/api/rest_v1/feed/featured/2017/05/04. That will allow you to directly test the image that the original bug was filed against.
  2. General POTD explore feed regression testing without mapping locally.

Screenshots/Videos (if applicable)

Before:
IMG_0219

After:
IMG_0220

Copy link
Contributor

@staykids staykids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Offers a pinch higher quality. The only thing I wonder is if this increase in image bucket size will make any kind of noticeable difference for folks on slower connections. But in my basic iPhone/iPad testing so far works fine.

@staykids staykids merged commit 45c1c7c into main Feb 2, 2021
@staykids staykids deleted the T164642 branch February 2, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants