Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article description - update terminology #3884

Merged
merged 6 commits into from
Mar 23, 2021
Merged

Article description - update terminology #3884

merged 6 commits into from
Mar 23, 2021

Conversation

tonisevener
Copy link
Collaborator

Fixes Phabricator ticket: https://phabricator.wikimedia.org/T261237

Notes

Test Steps

  1. Confirm mentions of "title description" in the app have changed to "article description". These changes can be found in the alert view after tapping the first section edit button, the description editing onboarding modal, the description editing modal,
    and the "Learn more" modal.

Screenshots/Videos (if applicable)

Before:
Screen Shot 2021-03-10 at 10 05 47 AM
Screen Shot 2021-03-10 at 10 05 26 AM
Screen Shot 2021-03-10 at 10 05 38 AM
Screen Shot 2021-03-10 at 10 05 55 AM

After:
Screen Shot 2021-03-10 at 2 17 35 PM
Screen Shot 2021-03-10 at 2 16 28 PM
Screen Shot 2021-03-10 at 2 16 38 PM
Screen Shot 2021-03-10 at 2 16 44 PM

@tonisevener tonisevener requested review from a team and mcleinman and removed request for a team March 10, 2021 20:45
@staykids staykids requested review from staykids and removed request for mcleinman and staykids March 17, 2021 21:01
@staykids
Copy link
Contributor

Didn't get to this one today so unassigning myself if it's holding anything up – otherwise, happy to jump back to it on Tuesday.

@staykids staykids self-requested a review March 23, 2021 20:02
Copy link
Contributor

@staykids staykids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 Looks good! I directly committed two minor fixes: removing extraneous space between an instance of "article description" in one string and after a couple of variable assignments.

@staykids staykids merged commit c871c41 into main Mar 23, 2021
@staykids staykids deleted the T261237 branch March 23, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants