-
-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update top read widget to be language variant aware #3895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a number of comments.
It also makes me think that I need to create a document with some details about the variant feature, because everything you've done is reasonable, but should be able to be done more simply.
It makes me realize I haven't given the team anything to help you all reason about doing variant-specific things.
Updated and should be ready for another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good!
Phabricator: https://phabricator.wikimedia.org/T277697 (this PR is a stepping stone towards addressing this task)
Notes
Previously, the top read widget would get into states where the title and description would be a. displayed in contrasting variants from one another and b. inconsistent with what's displayed in the Explore feed in the app. For example, if you were using
Serbian (Latin)
as your primary language, you might see aSerbian (Latin)
description but aSerbian (Cyrillic)
title.While it's certainly possible you may still see mixed character sets (for backend content reasons), this PR seeks to reach some sense of parity between the top read widget's displayed titles and descriptions and the in-app Explore feed's top read titles and descriptions.
WMFArticle
instead of theWMFFeedTopReadArticlePreview
Test Steps
I don't have great test steps here because getting the widgets to reload as desired has always been problematic, but generally:
Sometimes you'll encounter cases of the widgets not reloading, in which case sometimes deleting and re-adding the widget helps. The intent of this PR is not so much to address the reloading problem, but to help address the consistency issues of the titles and descriptions as described in step 2.