Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for edit pencil and reference link 3d touch issues. #415

Merged
merged 2 commits into from Jan 25, 2016
Merged

Fix for edit pencil and reference link 3d touch issues. #415

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd83bd6
Fix for 3d peek on edit pencil crashing.
montehurd Jan 25, 2016
5384bf8
Fix citation link 3d touch - make it not do preview.
montehurd Jan 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions Wikipedia/Code/WMFArticleContainerViewController.m
View file
Open in desktop
Expand Up @@ -867,7 +867,13 @@ - (nullable UIViewController*)previewingContext:(id<UIViewControllerPreviewing>)
}

- (UIViewController*)viewControllerForPreviewURL:(NSURL*)url {
if ([url.absoluteString isEqualToString:@""]) {
return nil;
}
if (![url wmf_isInternalLink]) {
if ([url wmf_isCitation]) {
return nil;
}
return [[SFSafariViewController alloc] initWithURL:url];
} else {
if (![url wmf_isIntraPageFragment]) {
Expand Down