Notification Center: iPad adjustments #4152
Conversation
mcleinman
requested review from
carolynlimadeo and
a team
and removed request for
carolynlimadeo
tonisevener
requested review from
tonisevener
and removed request for
mazevedofs
There was a problem hiding this comment.
@mcleinman thanks for helping us out with this! I have a few suggestions, let me know what you think.
| @@ -356,18 +357,18 @@ final class NotificationsCenterCell: UICollectionViewCell { | |||
| // Foreground and Background Container Constraints | |||
|
|
|||
| NSLayoutConstraint.activate([ | |||
| swipeBackgroundFillView.leadingAnchor.constraint(equalTo: contentView.leadingAnchor, constant: NotificationsCenterCell.swipeEdgeBuffer * 2.0), | |||
| swipeBackgroundFillView.leadingAnchor.constraint(equalTo: contentView.readableContentGuide.leadingAnchor, constant: NotificationsCenterCell.swipeEdgeBuffer * 2.0), | |||
There was a problem hiding this comment.
Can we adjust the placement of this readableContentGuide check elsewhere so that the swipe actions go all the way to the edge of the screen? This would line up better with how the saved articles cells act. Also it would be good if the background color when selected / highlighted can extend to the very edges too. We might want to confirm with @carolynlimadeo on this first.
Current PR:
Ideally:
There was a problem hiding this comment.
This has been fixed, thanks.
There was a problem hiding this comment.
@mcleinman I'm seeing something odd when I first load the screen - the messageSummaryLabel appears squished at first, then expands out to the proper width after 1 second. I didn't notice it in main, so I think this is related to the readableContentGuide changes. I'm testing this on an iPad Pro 11-inch, iOS 15.2. I'm also seeing it on iPhone.
There was a problem hiding this comment.
Good catch. I couldn't isolate why this was happening - tried a few different things. Thus, I went to your way of making the readable content guide work - that seems to work great, as well as fix this problem. Thank you!
|
I believe this is ready for another review. Thanks to @tonisevener for her help with parts of this! |
|
@mcleinman Thanks - this is looking good! Just a couple of last things - hopefully they're an easy fix: It looks like the non-Wikipedia project icons are still aligned to the edge. Screenshot from iOS15.2:
This summary label bleeds too far into the project icon area. Oddly I don't see this behavior in the compact horizontal size class, it wraps well before the project icon. Which is good, but surprising since I don't think we're doing anything differently via code for that. Screenshot from iOS15.2:
|
|
@tonisevener I think this is finally set. Fingers crossed. That last set was sloppy, this one should finally fix the readable content. |
Phabricator: https://phabricator.wikimedia.org/T286607
Notes
readableContentGuideinstead of requested exact numbers. Olga and Carolyn are comfortable with this.sourceRectfor the popover so it doesn't block the content. Current behavior was impact of giving a source size of zero.Test Steps
Screenshots/Videos
Filter margins (before/after)
Inbox margins (before/after)
Updated anchor for popover menu
Main screen - margins and cell height (before/after)
Large fonts
