Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wikipedia logo alignment when user is logged out #4183

Merged
merged 3 commits into from Apr 13, 2022
Merged

Conversation

staykids
Copy link
Contributor

@staykids staykids commented Apr 8, 2022

Phabricator: https://phabricator.wikimedia.org/T304452

Notes

When the user is logged in, use the existing centered title alignment for the navigation bar to display the notifications center bell and centered Wikipedia logo. But when the user is logged out, revert to the previous behavior of left/right aligning the Wikipedia logo via the large title display type.

Test Steps

  1. Log out, confirm the Wikipedia logo is edge aligned in the Explore feed.
  2. Log in, confirm the Wikipedia logo is centered between the Notifications Center button and the Settings button in the Explore feed.

logo_alignment

@staykids staykids requested review from a team and mazevedofs and removed request for a team April 8, 2022 18:57
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mazevedofs mazevedofs merged commit ca991a8 into main Apr 13, 2022
@mazevedofs mazevedofs deleted the T304452 branch April 13, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants