Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug from iOS overlay #4226

Merged
merged 3 commits into from May 23, 2022
Merged

fix bug from iOS overlay #4226

merged 3 commits into from May 23, 2022

Conversation

mcleinman
Copy link
Contributor

Phabricator: https://phabricator.wikimedia.org/T305112

Notes

  • When a user was in our app, selected a word/phrase, then tapped "Look Up" (and entered the iOS overlay), then tapped the "Siri Knowledge" cell (if available), then tapped "Wikipedia": iOS's overlay would open the link in the app, but currentNavigationController would present the new article VC on the iOS Look Up VC, not the original article VC (as expected). Since the iOS Look Up VC would deinit nearly immediately, the new article would close after a split second.
  • I tested this on iPad and iOS

Test Steps (please test on iPhone and iPad)

  1. In our app, select a word/phrase
  2. then tap "Look Up" (and enter the iOS overlay)
  3. then tap the "Siri Knowledge" cell (if available - it should be for most places/concepts/etc)
  4. then tap "Wikipedia"
  5. Confirm: the link opens in the app, and the new article is showing as expected
  6. Confirm: The back button goes to the prior article

@mcleinman mcleinman requested review from a team and staykids and removed request for a team May 17, 2022 23:23
@tonisevener tonisevener requested review from tonisevener and removed request for staykids May 23, 2022 13:31
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me!

@tonisevener tonisevener merged commit 372478c into main May 23, 2022
@tonisevener tonisevener deleted the T305112 branch May 23, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants