Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe and unsubscribe to talk page topics #4324

Merged
merged 9 commits into from Sep 22, 2022
Merged

Conversation

mazevedofs
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T311639

Notes

  • Add calls to the subscription APIs to get all active subscriptions and subscribe/unsubscribe to a topic
  • Update the talk page cells UI accordingly

Test Steps

  1. Go to a talk page, tap the button to subscribe/unsubscribe to a topic
  2. Leave the page and when returning, check if your subscriptions are correctly updated

@tonisevener tonisevener self-assigned this Sep 20, 2022
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! It's working well in my (limited) testing. I have mostly some small tweaks, and one request to optimistically flip the button state instead of waiting for the fetch to go through. Thanks!

Wikipedia/Code/TalkPageDataController.swift Outdated Show resolved Hide resolved
Wikipedia/Code/TalkPageViewModel.swift Outdated Show resolved Hide resolved
Wikipedia/Code/TalkPageViewModel.swift Outdated Show resolved Hide resolved
Wikipedia/Code/TalkPageViewModel.swift Outdated Show resolved Hide resolved
Wikipedia/Code/TalkPageViewModel.swift Outdated Show resolved Hide resolved
Wikipedia/Code/TalkPageViewController.swift Outdated Show resolved Hide resolved
@tonisevener tonisevener removed their assignment Sep 20, 2022
@tonisevener tonisevener merged commit f66579d into main Sep 22, 2022
@tonisevener tonisevener deleted the subscribe-topics branch September 22, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants