New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add find in page to talk pages #4376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great to see! Nice job working with the existing search view.
I have a few actual code review comments, and then the rest are suggestions I tinkered with for getting the scrolling to work a bit more predictably. Let me know what you think!
@tonisevener Thanks for the great suggestions - updated and ready for another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I had to adjust a little bit from some merge conflicts from main
. We are now letting talk page items display that have no replies, so that caused some adjustments in the view models. main
is also utilizing the removingInitialNewlineCharacters
method in more places, which threw off some of the ranges for the active highlight.
I patched these up as best I could, but it could probably use more attention with the next PR. I'm going to go ahead and merge to get the current functionality in though.
I also noticed that it's no longer sluggish when I type, so perhaps the move away from reloadData
improved that.
Phabricator: https://phabricator.wikimedia.org/T319470 (partially)
Notes
Adds find in page to talk pages.
More refinement work in a forthcoming PR remains, including:
Test Steps