Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T322805
Notes
This PR adds the event logging for importing shared reading lists.
Test Steps
MobileWikiAppiOSReadingLists
in the url.category: shared
,action: receive_start
, andmeasure: 8
(the number of articles that are shared in this particular landing page link).category: shared
andaction: receive_cancel
Create reading list
button. Confirm you see an event withcategory: shared
,action: receive_finish
, andmeasure: 8
.category: shared
,action: survey_shown
.category: shared
,action: survey_clicked
.