Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading list import logging #4400

Merged
merged 6 commits into from Nov 17, 2022
Merged

Reading list import logging #4400

merged 6 commits into from Nov 17, 2022

Conversation

tonisevener
Copy link
Collaborator

Phabricator:
https://phabricator.wikimedia.org/T322805

Notes

This PR adds the event logging for importing shared reading lists.

Test Steps

  1. Fresh install an app, then toggle on logging either via the onboarding flow or app Settings.
  2. Inspect traffic via a proxy, look for traffic with MobileWikiAppiOSReadingLists in the url.
  3. Trigger the reading list import modal by visiting the landing page in Safari.
  4. Via proxy, confirm you see an event call with category: shared, action: receive_start, and measure: 8 (the number of articles that are shared in this particular landing page link).
  5. Tap X. Confirm you see an event with category: shared and action: receive_cancel
  6. Repeat step 3, then tap Create reading list button. Confirm you see an event with category: shared, action: receive_finish, and measure: 8.
  7. Wait until survey appears on the reading list detail screen. Confirm you see an event with category: shared, action: survey_shown.
  8. Tap the take survey button. Confirm you see an event with category: shared, action: survey_clicked.

@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team November 16, 2022 20:07
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great!

@mazevedofs mazevedofs merged commit f123316 into main Nov 17, 2022
@mazevedofs mazevedofs deleted the reading-list-import-logging branch November 17, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants