Hide sparkline in top read widget if size category exceeds extra large #4419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staykids
requested review from
a team and
tonisevener
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T323946
Notes
This PR hides the sparkline and description text present in the large top read widget rows if the user changes their accessibility text size to be larger than extra large. Previously, for large text sizes, the sparkline would overlap with next row text if the user had their device set to larger type sizes. The larger size widget will now more closely resemble the medium sized widget in these cases of larger text sizes.
Test Steps
Screenshots/Videos