Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color cleanup #4476

Merged
merged 7 commits into from
Mar 6, 2023
Merged

Color cleanup #4476

merged 7 commits into from
Mar 6, 2023

Conversation

mazevedofs
Copy link
Collaborator

@mazevedofs mazevedofs commented Feb 22, 2023

Phabricator: https://phabricator.wikimedia.org/T329559

Notes

  • This PR adds color literals to the Colors class, so we can more easily transition them to the components repo if needed
  • System colors such as .clear, and .systemBackground were not replaced.
  • Edit: My idea when naming the colors that were moved into the Colors extension was to provide context as to where they are used in the app, so feel free to suggest better names.

Test Steps

  1. Run the app, do a simple smoke test
  2. Special attention to the settings screens and attributed strings
  3. An extra step would be to search the codebase for UIColor literals colors instantiated with wmf_colorWithHex(_ hex: Int)

@mazevedofs mazevedofs requested review from a team and tonisevener and removed request for a team February 22, 2023 15:40
@tonisevener tonisevener self-assigned this Feb 22, 2023
Wikipedia/Code/WMFSettingsMenuItem.m Outdated Show resolved Hide resolved
WMF Framework/Theme.swift Outdated Show resolved Hide resolved
WMF Framework/Theme.swift Outdated Show resolved Hide resolved
WMF Framework/Theme.swift Outdated Show resolved Hide resolved
@tonisevener tonisevener removed their assignment Feb 23, 2023
Remove NSAttributedString+WMFSavedPagesAttributedStrings header and implementation files
Add missing settings yellow color
@tonisevener tonisevener merged commit 45679da into main Mar 6, 2023
@tonisevener tonisevener deleted the color-cleanup branch March 6, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants