Improve state restoration performance #4531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonisevener
changed the title
staykids
reviewed
May 25, 2023
| @@ -21,6 +21,78 @@ final class NavigationStateController: NSObject { | |||
| private typealias Presentation = ViewController.Presentation | |||
| private typealias Info = ViewController.Info | |||
|
|
|||
| /// Finds the topmost article from persisted NavigationState and pushes it onto navigationController | |||
| @objc func restoreLastArticle(for navigationController: UINavigationController, in moc: NSManagedObjectContext, with theme: Theme, completion: @escaping () -> Void) { | |||
| guard let tabBarController = navigationController.viewControllers.first as? UITabBarController else { | |||
There was a problem hiding this comment.
I think this warning can be alleviated with:
guard navigationController.viewControllers.first is UITabBarController else { ...(Also very cool to see the Xcode Cloud warnings propagating up to the code review layer here in GitHub!)
There was a problem hiding this comment.
staykids
reviewed
May 26, 2023
| return childArticleViewController ?? articleViewController | ||
| } | ||
|
|
||
| /// Attempts to restore user's entire heirarchy, included presented modal navigation stacks. Currently not in use in preference of restoreLastArticle to improve loading times. |
There was a problem hiding this comment.
@tonisevener Super minor: typos heirarchy → hierarchy, included → including.
There was a problem hiding this comment.
Ah sorry about that, this is fixed (also in other places I found).
staykids
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T337073
Notes
This PR simplifies state restoration to only the user's last read article, to reduce the chance of prolonged state restoration times upon launch. It also fixes a couple of bugs that originally caused a situation where the user was stuck in a Reading List Detail modal state upon restoration. Test steps for each commit are below.
6485b92 - This fixed a bug where there was a missing close button upon state restoration to a modal Reading List Detail screen. This area of code isn't actually hit anymore due to later commits in this PR, but I decided to fix it anyway in case we bring full view controller hierarchy restoration back in the future. You must git checkout this SHA if you want to test it. Test steps for this are:
main.92c22db and 0b9740a - This prevents pushing on an article from a Reading List Detail modal. Instead it dismisses the modal upon cell tap, then pushes on the article onto the stack below. Test steps are:
b4c0bcf - This is the bigger change with simplifying state restoration. I kept the way we persist navigation state as-is, but now upon state restoration, this only seeks out the top-most article, and pushes that onto the root navigation stack.
Marking as Draft while we confirm this direction with product / design.