Send revision ID on save success event log #4544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazevedofs
requested review from
a team and
staykids
and removed request for
a team
staykids
reviewed
Jun 13, 2023
| @@ -184,7 +184,7 @@ extension ArticleViewController: SectionEditorViewControllerDelegate { | |||
| case .success(let changes): | |||
| dismiss(animated: true) | |||
| waitForNewContentAndRefresh(changes.newRevisionID) | |||
| EditAttemptFunnel.shared.logSaveSuccess(articleURL: self.articleURL) | |||
| EditAttemptFunnel.shared.logSaveSuccess(articleURL: self.articleURL, revisionId: Int(changes.newRevisionID)) | |||
There was a problem hiding this comment.
No change needed here, and it looks like we already use this pattern elsewhere, but just wanted to mention: generally for important casting situations where there's possible precision loss, I'll just future proof and use the higher level NSNumber and allow it to handle doing the right thing, so something like NSNumber(value: changes.newRevisionID).intValue here. But my understanding of this specific case is that we're ok without that, with Int on the devices that can run our app itself being a Int64 and it being unlikely we hit the max value revision id.
There was a problem hiding this comment.
Yeah, I was unsure about that too; it's a good thing to keep in mind for a future time
staykids
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T337331
Notes
saveSuccess()event logTest Steps
revision_idfield.