-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD MERGE] Update diff view for forthcoming Watchlist feature #4552
Conversation
+ plus automatic project.pbxproj file changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm going to go ahead and merge. I think that will be easier to manage moving forward than stacked PRs. Note I did a few minor commits at the end (updating with main
, turning the feature flag on).
lazy var moreButton: IconBarButtonItem = { | ||
// DIFFTODO: Add menu item images | ||
let menu = UIMenu(title: "", options: .displayInline, children: [ | ||
UIAction(title: CommonStrings.rollback, attributes: [.destructive], handler: { [weak self] _ in self?.tappedRollback() }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI, visibility of the rollback option may need to changed based on permissions data from the API. I can look into this once the API calls are merged.
Phabricator: https://phabricator.wikimedia.org/T335579 (partially)
Notes
Updates diff view to new design in support of forthcoming Watchlist feature. I've retained the single revision view instead of removing it entirely mostly as a safety net, as there may be special cases or entry points where it still makes sense to see a single revision (like an article that only has a single revision).
Ready for review - feel free to merge if you feel it's ready to be merged, or otherwise wait for forthcoming stacked PRs before merging into main.
Remaining work to come in future stacked PRs includes:
Test Steps