Perform deeper database cleanup upon Settings clear cache #4574
Conversation
staykids
requested review from
a team and
staykids
and removed request for
a team
| - (void)clearCache { | ||
|
|
||
| [NSObject cancelPreviousPerformRequestsWithTarget:self selector:@selector(showClearCacheInProgressBanner) object:nil]; | ||
| [self performSelector:@selector(showClearCacheInProgressBanner) withObject:nil afterDelay:1.0]; |
There was a problem hiding this comment.
I haven't yet experienced seeing this banner, but only because I guess my explore feed content when testing hasn't been large enough for the deletion to take long. Seems like a good delay value here (for me at least!) to not have to see quick double banners appear!
There was a problem hiding this comment.
Good, glad you haven't seen any double banners!
Yeah, this may be me going overboard on performance testing, but I (programmatically) loaded a year's worth of Explore feed data and tested this on my old iPhone 7. It caused an alarming UI freeze in this situation, which is why I added 4c244cb to perform the cleanup on a different thread and show banners.
So if something will take a while, the user will see that a cleanup started via the banner, but the UI is still responsive. They can then go back to the Explore feed. Once cleanup completes, the Explore feed refreshes and the "complete" banner displays.
|
|
||
| @objc private func databaseHousekeeperDidComplete() { | ||
| DispatchQueue.main.async { | ||
| self.refresh() |
There was a problem hiding this comment.
I'm on occasion running into a situation where the content is deleted, but the explore feed doesn't refresh (see screenshot). I have English (primary) and Arabic in my languages, scroll several days worth of explore feed content, then perform a Settings > Clear cached data operation. I haven't been able to reliably reproduce this though yet. Certainly not a dealbreaker as pulling to refresh the explore feed still refreshes the feed, but just wanted to check in to see if you'd encountered anything like this yourself.
There was a problem hiding this comment.
Good catch - I hadn't noticed that. I am occasionally able to reproduce. When watching the traffic, I notice AR Wikipedia sometimes takes a long time to load the featured endpoint, particularly with older dates. Maybe its a server-side caching thing? In my testing, July 15th took 1+ minutes to load, and July 14th timed out.
I suspect at this line, it's exiting early, due to a previous slow paging operation. I could maybe bypass this check in situation if you think I should - let me know what you think.
Phabricator:
https://phabricator.wikimedia.org/T341104
Notes
This PR adds some additional database and caching cleanup logic to the Settings > Clear Cache action. It leans on our existing
WMFDatabaseHousekeeperandSharedContainerCacheHousekeeping(which we currently trigger via BackgroundTasks). I'm passing in a newWMFCleanupLevelparameter to indicate that from these contexts we want to do a deeper clean in hopes of removing vandalism. In regards to the requirements of https://phabricator.wikimedia.org/T341104, we are deleting all Explore feed data and refreshing it upon completion.Test Steps