Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tapping diff header title to visit associated page #4677

Merged
merged 2 commits into from Nov 29, 2023
Merged

Allow tapping diff header title to visit associated page #4677

merged 2 commits into from Nov 29, 2023

Conversation

staykids
Copy link
Contributor

Phabricator: https://phabricator.wikimedia.org/T347915 (partially)

Notes

Adds "hyperlink" to view associated article from the diff/revision view.

Test Steps

  1. Open the diff/revision view (from a Watchlist revision or article history)
  2. Confirm title appears in theme's link color
  3. Confirm tapping the title label navigates user to associated article

@staykids staykids requested review from a team and mazevedofs and removed request for a team November 14, 2023 23:55
@tonisevener tonisevener self-assigned this Nov 29, 2023
tonisevener
tonisevener approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tonisevener tonisevener removed their assignment Nov 29, 2023
@tonisevener tonisevener merged commit 83cb03f into main Nov 29, 2023
4 checks passed
@tonisevener tonisevener deleted the watchlist/tap-header branch November 29, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonisevener tonisevener tonisevener approved these changes

@mazevedofs mazevedofs Awaiting requested review from mazevedofs mazevedofs was automatically assigned from wikimedia/ios

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@staykids @tonisevener