Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native Page Editor Container and UI Tests #4682

Merged
merged 42 commits into from Dec 5, 2023
Merged

Native Page Editor Container and UI Tests #4682

Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
30955d0
Native source editor component adjustments
mazevedofs Oct 30, 2023
e78259a
Add WKSourceEditorLocalizedStrings struct
mazevedofs Nov 1, 2023
e84d713
Add native page editor localized strings
mazevedofs Nov 8, 2023
8180953
Inject localized strings on page editor
mazevedofs Nov 8, 2023
e5e4a77
Add ui testing bundle target
tonisevener Nov 9, 2023
de369d7
Update UI Testing bundle deployment target to iOS 15
tonisevener Nov 9, 2023
00f42b2
Add UITests Test plan
tonisevener Nov 9, 2023
e4f5d0d
Add UITests Test in Wikipedia scheme > Test (leaving default unselected)
tonisevener Nov 9, 2023
cdf80da
Add UITests configuration in Project > Info, duplicated from Test con…
tonisevener Nov 9, 2023
f15754f
Update macro Test flag in UITests configuration to UITest for all tar…
tonisevener Nov 9, 2023
04580b2
Change explore feed search bar color to help debug which macro is used
tonisevener Nov 9, 2023
cdcadaa
Duplicate Wikipedia scheme into WikipediaUITests scheme
tonisevener Nov 9, 2023
3fdeaa6
Delete UITests test plan from Wikipedia scheme
tonisevener Nov 9, 2023
6082bef
Delete Wikipedia test plan from WikipediaUITests scheme
tonisevener Nov 9, 2023
c46aba3
Add UITests test plan to WikipediaUITests scheme
tonisevener Nov 9, 2023
5a129de
Point to UITests build configuration in WikipediaUITests scheme > Tes…
tonisevener Nov 9, 2023
6466d5c
Delete WikipediaUnitTests row in WikipediaUITests scheme > Build sect…
tonisevener Nov 9, 2023
ef9c822
WIP
mazevedofs Nov 13, 2023
210c5e6
Wip tests
mazevedofs Nov 13, 2023
8d0e867
Setup new UITest configurations for themes and other languages
mazevedofs Nov 16, 2023
7fc9b89
Inject strings on test
mazevedofs Nov 16, 2023
ffe5f13
Add UI Tests helper controller
mazevedofs Nov 21, 2023
5a146fe
Present helper controller on UI Tests
mazevedofs Nov 21, 2023
117c6dd
Keep main Wikipedia target defaul tests as unit tests
mazevedofs Nov 21, 2023
5e95d77
Fix whitespace
mazevedofs Nov 21, 2023
073c79b
Configure uitest schema
mazevedofs Nov 21, 2023
3cd246f
Skip onboarding on UI tests
mazevedofs Nov 21, 2023
ad5967a
Localisation updates from https://translatewiki.net.
translatewiki Nov 13, 2023
984a316
Import translations from TranslateWiki
invalid-email-address Nov 13, 2023
51681af
Manually increment version to 7.4.6.
staykids Nov 13, 2023
d51d140
Remove UI tests from Test phase on main Wikipedia schema configuration
mazevedofs Nov 22, 2023
caa1c6e
Add string substitution to comment on localized strings
mazevedofs Nov 22, 2023
1460822
Merge branch 'main' of https://github.com/wikimedia/wikipedia-ios int…
mazevedofs Nov 22, 2023
19701c1
Localization updates
mazevedofs Nov 22, 2023
2b2b3e1
Fix theme selection for UI tests
tonisevener Nov 29, 2023
554faff
Remove references to UITests in schemes that don't need it
tonisevener Nov 29, 2023
7255933
Merge branch 'main' into page-editor-ui-tests
tonisevener Nov 30, 2023
ad1d44f
Compile fixes
tonisevener Nov 30, 2023
4aa4e2a
Fix tests
tonisevener Dec 1, 2023
70a35b7
Code review feedback changes
mazevedofs Dec 4, 2023
1ea8656
Add procol conformance to ExploreViewController for UITests, localiza…
mazevedofs Dec 4, 2023
22b0bc4
Merge branch 'main' into page-editor-ui-tests
tonisevener Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions Wikipedia/Code/ExploreViewController.swift
View file
Open in desktop
Expand Up @@ -593,7 +593,15 @@ class ExploreViewController: ColumnarCollectionViewController, ExploreCardViewCo
updateSettingsButton()

searchBar.apply(theme: theme)
#if DEBUG
tonisevener marked this conversation as resolved.
Show resolved Hide resolved
searchBarContainerView.backgroundColor = UIColor.blue
#elseif TEST
searchBarContainerView.backgroundColor = UIColor.red
#elseif UITEST
searchBarContainerView.backgroundColor = UIColor.green
#else
searchBarContainerView.backgroundColor = theme.colors.paperBackground
#endif
collectionView.backgroundColor = .clear
view.backgroundColor = theme.colors.paperBackground
for cell in collectionView.visibleCells {
Expand Down