Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diffs: top align from/to container stack view #4684

Merged
merged 1 commit into from Nov 29, 2023
Merged

Diffs: top align from/to container stack view #4684

merged 1 commit into from Nov 29, 2023

Conversation

staykids
Copy link
Contributor

Phabricator: https://phabricator.wikimedia.org/T347425

Notes

Fixes an alignment issue where the from/to revision metadata was not rendering as expected.

Test Steps

  1. Open a diff comparison view between two revisions where one revision does not contain an edit description. (Here's an example I tested with: https://en.wikipedia.org/w/index.php?title=YouTube&diff=1187392832&oldid=1187244209)
  2. In the header from/to edit metadata stacks, confirm the labels appear top aligned and are not filled with extraneous inter-item space.

diff_header

@staykids staykids requested review from a team and mazevedofs and removed request for a team November 29, 2023 21:31
@tonisevener tonisevener self-assigned this Nov 29, 2023
tonisevener
tonisevener approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tonisevener tonisevener merged commit e5a5665 into main Nov 29, 2023
4 checks passed
@tonisevener tonisevener deleted the T347425 branch November 29, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonisevener tonisevener tonisevener approved these changes

@mazevedofs mazevedofs Awaiting requested review from mazevedofs mazevedofs was automatically assigned from wikimedia/ios

Assignees

@tonisevener tonisevener

Labels
None yet
Milestone
No milestone
2 participants
@staykids @tonisevener