Bug fix - Native Editor new input view bug #4696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…putView - Fixes strange bug of empty keyboard input view on iPad mini
tonisevener
requested review from
a team and
staykids
and removed request for
a team
tonisevener
requested review from
mazevedofs
and removed request for
staykids
mazevedofs
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T344508
Notes
My iPad mini (device-only) would show an empty input view for the native editor. I couldn't figure out why this was happening, but I suspect it had something to do with the embedded view controllers or navigation controller, since simple test views displayed fine for me.
I rewrote and simplified these views to be a single input view, to more closely match what I've seen proposed from design. The UI is not complete, but I think we can merge this first and fine-tune in a followup PR once T344508 is updated with final mocks.
Test Steps
Screenshots/Videos
Before (iPad mini bug):
After:
