Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix widget presentation on iOS 17 #4701

Merged
merged 5 commits into from Dec 14, 2023
Merged

Fix widget presentation on iOS 17 #4701

merged 5 commits into from Dec 14, 2023

Conversation

staykids
Copy link
Contributor

Phabricator: https://phabricator.wikimedia.org/T346810

Notes

Conforms to iOS 17's container background API for widgets to fix the presentation of widgets on the home screen when built with Xcode 15. As a result, also opts into StandBy on iPhone.

Test Steps

  1. Build this branch using Xcode 15, and run on iOS 17 device or simulator.
  2. Add one of each type of widget to the home screen and confirm they render without the margins seen in Phab task (can also confirm they render without margins in the widget gallery when adding widgets)
  3. Optionally, enable StandBy and confirm each of the small variant widgets render as expected.

Screenshots

Here're screenshots of the widgets in StandBy mode:

standby

@staykids staykids requested review from a team and tonisevener and removed request for a team December 12, 2023 22:14
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, I'd like to hold merging until we're past releasing 7.4.6, since we'll have to change our Xcode version.

@tonisevener tonisevener merged commit f19c64b into main Dec 14, 2023
4 checks passed
@tonisevener tonisevener deleted the T346810 branch December 14, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants