Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Editor - Add basic undo / redo support #4719

Merged
merged 5 commits into from Jan 24, 2024
Merged

Conversation

tonisevener
Copy link
Collaborator

Phabricator:
https://phabricator.wikimedia.org/T348088

Notes

This PR connects the undo / redo buttons to the editor's undo manager. It also disables the progress button until the text has changed.

Test Steps

  1. On Staging, open an article editor. Undo, Redo, and Next buttons should be disabled.
  2. Make a change in the text view. Confirm undo button enables.
  3. Tap undo button. Confirm change is undone.
  4. Tap redo button. Confirm change is redone.
  5. Confirm Next button only enables when there are changes to publish.

Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@mazevedofs mazevedofs merged commit 8e39b97 into main Jan 24, 2024
4 checks passed
@mazevedofs mazevedofs deleted the native-editor-undo-redo branch January 24, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants