-
-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native Editor - Input view design + icon work #4729
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1bd4939
Add new colors and fonts
tonisevener e2b809b
Set default SFSymbolIcon to subheadline, allow palette colors param
tonisevener d58f00c
Updates to accessory input toolbar classes to more closely match mocks
tonisevener 3edda53
Create new components for input view header buttons and scrolling con…
tonisevener 15c1578
Create new component for input view multi button for formatting
tonisevener 5264959
Use new work in WKEditorInputView
tonisevener dae0fff
Delete old unused classes
tonisevener 660a2ab
Merge branch 'main' into native-editor-input-views
tonisevener 773ccc6
Fix hidden expand button bug on iPad
tonisevener 385bb7a
Improve scaling for find and replace icons
tonisevener d6fd283
Update editor navigation bar with new icons
tonisevener 550fb68
Reading themes popover adjustments
tonisevener ab1ee4b
Use new icon for format text accessibility input view
tonisevener 7682f80
Resign first responder before presenting reading themes so that it si…
tonisevener 419cb20
Add keyboard shadows
tonisevener File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
9 changes: 0 additions & 9 deletions
9
Components/Sources/Components/Assets.xcassets/editor/Contents.json
This file was deleted.
Oops, something went wrong.
15 changes: 0 additions & 15 deletions
15
Components/Sources/Components/Assets.xcassets/editor/format-heading.imageset/Contents.json
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-6.49 KB
...ents/Sources/Components/Assets.xcassets/editor/format-heading.imageset/format-heading.pdf
Binary file not shown.
2 changes: 1 addition & 1 deletion
2
...editor/format-text.imageset/Contents.json → ...xcassets/separator.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "format-text.pdf", | ||
"filename" : "separator.pdf", | ||
"idiom" : "universal" | ||
} | ||
], | ||
|
Binary file renamed
BIN
+5.67 KB
...itor/format-text.imageset/format-text.pdf → ...xcassets/separator.imageset/separator.pdf
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! I didn't know about this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mazevedofs yep, it's the newer style of button configuration for UIKit. I can't remember if this was required for this particular button, but I needed it to add padding to the buttons in
WKEditorMultiButton
without triggering project warnings. We'll need to use a similar approach inWKSmallMenuButton
to remove those warnings.