Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native Editor - Finalize VoiceOver labels #4730

Merged
merged 4 commits into from Jan 30, 2024
Merged

Native Editor - Finalize VoiceOver labels #4730

merged 4 commits into from Jan 30, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator:
https://phabricator.wikimedia.org/T347870#9400922

Notes

This PR builds off of the work in #4729 to wrap up VoiceOver labels on the new editor views.

Test Steps

  1. Navigate to editor on Staging. Turn on Voice Over.
  2. Confirm labels on all buttons in the toolbars and input view make sense.

@tonisevener tonisevener added the Dependent PR PR is dependent on another PR - merge dependent PR first and update branch before merging label Jan 30, 2024
Base automatically changed from native-editor-input-views to main January 30, 2024 18:00
mazevedofs
mazevedofs approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mazevedofs mazevedofs merged commit 95be67f into main Jan 30, 2024
4 checks passed
@mazevedofs mazevedofs deleted the native-editor-finalize-voice-over branch January 30, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazevedofs mazevedofs mazevedofs approved these changes

Assignees
No one assigned
Labels
Dependent PR PR is dependent on another PR - merge dependent PR first and update branch before merging
Milestone
No milestone
2 participants
@tonisevener @mazevedofs