Image recommendations - Add utility class to style HTML #4759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonisevener
requested review from
a team and
staykids
and removed request for
a team
staykids
reviewed
Feb 24, 2024
| public static func nsAttributedStringFromHtml(_ html: String, styles: Styles) throws -> NSAttributedString { | ||
| let attributedString = NSMutableAttributedString(string: html) | ||
| let paragraphStyle = NSMutableParagraphStyle() | ||
| paragraphStyle.lineSpacing = 3 |
There was a problem hiding this comment.
What do you think about propagating this value through Styles as well?
There was a problem hiding this comment.
Done! One thing that's still a bit awkward here is that SwiftUI adds line spacing as a modifier, outside of the utility. I couldn't find any line spacing key while making AttributedString. I guess we could consider making a WKHtmlText component or something, just for SwiftUI, with line spacing applied within so that we don't have to remember to add this modifier every time. Let me know what you think.
There was a problem hiding this comment.
Yeah a component that itself encapsulates those custom modifiers makes sense in the future to me too.
staykids
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T356816
Notes
This PR creates a utility class for converting html strings into NSAttributedString and AttributedString. We need the AttributedString conversion to support attributed SwiftUI text views in the Components framework.
I believe I have covered all of the major needs from our old class in String+Html.swift, though note that I didn't strictly follow it. This utility supports:
I created some dummy UI to see both UI frameworks in action. Followup PRs for this task will be reusing the article intro view from the
T347121/prototype, and connecting it to live data.Test Steps
Screenshots