Use web form for Account Vanishing flow #4770
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T336494 &
https://phabricator.wikimedia.org/T356210
Notes
This PR deletes our old native vanishing form and replaces it with the web form. Initially I had some odd logged out states when switching accounts and reloading the form. I was able to fix it with this line, which essentially turns our web view into a private browsing session. I don't think this will cause major ill effects, since we're copying the session cookies over upon load. We'll probably drop cookies saved from other in-app web views though. I tested some of the donation payment methods and didn't see any issues.
Test Steps