Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use web form for Account Vanishing flow #4770

Merged
merged 9 commits into from
Mar 6, 2024
Merged

Conversation

tonisevener
Copy link
Collaborator

Phabricator:
https://phabricator.wikimedia.org/T336494 &
https://phabricator.wikimedia.org/T356210

Notes

This PR deletes our old native vanishing form and replaces it with the web form. Initially I had some odd logged out states when switching accounts and reloading the form. I was able to fix it with this line, which essentially turns our web view into a private browsing session. I don't think this will cause major ill effects, since we're copying the session cookies over upon load. We'll probably drop cookies saved from other in-app web views though. I tested some of the donation payment methods and didn't see any issues.

Test Steps

  1. Log into app
  2. Go to a user page. You can get there through article revision history > user name button > user page
  3. This will load the mobile web view, tap the bottom Desktop button in the footer.
  4. On this new web view, confirm you see a logged in state in the top right corner.
  5. Now go to the Vanishing view under Account.
  6. After warning, confirm web view loads and the correct username is populated.
  7. Feel free to submit the form for a test account if you want (I already tested this, and QA can test it more).
  8. Go back to Account and log out. Go to another user page > Desktop web view and confirm you are in a logged out state.
  9. Log into a different account.
  10. Go to vanishing form. Confirm correct username is populated.

@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team February 29, 2024 21:28
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tonisevener tonisevener merged commit 691dbf0 into main Mar 6, 2024
4 checks passed
@tonisevener tonisevener deleted the vanishing/web-view-flow branch March 6, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants