New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Recommendations: Bottom Modal Sheet #4777
Conversation
…o half-sheet-modal-UI
…o half-sheet-modal-UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I have mainly minor things. I have an alternative approach to avoid the sizing calculations you mentioned, but I didn't notice any layout bugs on how it's acting currently so it can be optional.
I also notice a crash with these steps:
- Go to first recommendation on iPhone (I've been testing iPhone 15 Pro simulator). Tap "View article"
- Go back, then tap "Not sure"
- App crashes.
WKData/Sources/WKData/Models/Image Recommendations/WKImageRecommendationData.swift
Show resolved
Hide resolved
.../Suggested Edits/Image Recommendations/WKImageRecommendationsBottomSheetViewController.swift
Show resolved
Hide resolved
.../Components/Suggested Edits/Image Recommendations/WKImageRecommendationBottomSheetView.swift
Show resolved
Hide resolved
.../Components/Suggested Edits/Image Recommendations/WKImageRecommendationBottomSheetView.swift
Show resolved
Hide resolved
.../Components/Suggested Edits/Image Recommendations/WKImageRecommendationBottomSheetView.swift
Show resolved
Hide resolved
.../Components/Suggested Edits/Image Recommendations/WKImageRecommendationBottomSheetView.swift
Show resolved
Hide resolved
.../Components/Suggested Edits/Image Recommendations/WKImageRecommendationBottomSheetView.swift
Show resolved
Hide resolved
.../Components/Suggested Edits/Image Recommendations/WKImageRecommendationsViewController.swift
Show resolved
Hide resolved
|
||
private func setupToolbar() { | ||
let spacer = UIBarButtonItem(systemItem: .flexibleSpace) | ||
toolbar.setItems([yesToolbarButton, spacer, noToolbarButton, spacer, notSureToolbarButton], animated: true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some constraint errors in the console when these are set, but so far I haven't figured out what's causing it.
.../Components/Suggested Edits/Image Recommendations/WKImageRecommendationsViewController.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to merge to unblock dependent tasks. Feedback will be addressed in a followup PR.
Phabricator: https://phabricator.wikimedia.org/T356818
Notes
Test Steps