Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add app install ID to EditAttemptStep #4782

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Add app install ID to EditAttemptStep #4782

merged 2 commits into from
Mar 26, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator:
https://phabricator.wikimedia.org/T358735

Notes

This PR logs app_install_id as a part of our EditAttemptStep metrics.

Test Steps

  1. Go to an article, tap overflow menu > "Edit source"
  2. Watch the console and confirm you see an EditAttemptStep payload. Confirm you see a populated "app_install_id" key in the event.
  3. (Optional) Confirm you see the same payload post when proxying, and the response is successful.

@tonisevener tonisevener requested review from a team and staykids and removed request for a team March 20, 2024 18:23
@staykids staykids self-assigned this Mar 26, 2024
staykids
staykids approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@staykids staykids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 looking like successful 201s to the metrics platform that include the install ID.

@staykids staykids merged commit e4f588d into main Mar 26, 2024
4 checks passed
@staykids staykids deleted the T358735 branch March 26, 2024 20:35
@staykids staykids removed their assignment Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staykids staykids staykids approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@tonisevener @staykids