Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Recommendations - Prevent view from rotating on iPhone #4827

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Image Recommendations - Prevent view from rotating on iPhone #4827

merged 3 commits into from
Apr 30, 2024

Conversation

mazevedofs
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T360037

Notes

  • Prevents Image recs view from rotating on iPhone
  • Rotating on iPad is still possible in all directions
  • The orientation is locked on the ImageRecommendationsViewController. Since this VC is embedded in a Navigation Controller, this PR overrides some properties in our Root Nav Controller to allow for each child VC to control rotation

Test Steps

  1. Run the app on an iPhone, go to image recommendations
  2. Make sure the device rotation is unlocked
  3. Rotate in all directions
  4. The view should not rotate
  5. test other features - they should rotate normally
  6. test on iPad - the Image Recs view should be able to rotate

@tonisevener tonisevener merged commit f5053cf into main Apr 30, 2024
4 checks passed
@tonisevener tonisevener deleted the image-recs-landscape branch April 30, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonisevener tonisevener tonisevener approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@mazevedofs @tonisevener