Image Recommendations - Error Handling #4828
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T358928
Notes
This PR adds some error handling to the image recommendations feature. In summary, it delegates out any loading error to
ExploreViewController
, which then displays it usingWMFAlertController
. It also changes out the content view of image recommendations to a new error state component.EditSaveViewController
(Edit Summary view) already had a lot of working error handling from being in the editor flow, so I left that as-is.Test Steps
The only error state that is easy to test is a network connection. Other things you can try is to temporarily mess up the url creation methods in the data controllers, like the article summary endpoint. The server should respond with some sort of error if you're missing the
summary
in the url path, for example.