Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image recommendations - Improve error handling #4831

Merged
merged 3 commits into from
May 2, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T358928#9761814

Notes

Adding internet connection error banners on the "Add image details" and "Preview" views.

Test Steps

  1. Go to image recommendations
  2. Before tapping "yes", turn on Airplane mode.
  3. Confirm "No internet connection" banner appears after tapping Yes.
  4. Tap Next
  5. Confirm "No internet connection" banner appears on Preview.

@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team May 1, 2024 21:11
@mazevedofs mazevedofs merged commit 3e5773b into main May 2, 2024
4 checks passed
@mazevedofs mazevedofs deleted the image-recs/error-handling-2 branch May 2, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants