Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image recommendations - Present announcement on app foreground #4833

Merged
merged 2 commits into from
May 2, 2024
Merged

Image recommendations - Present announcement on app foreground #4833

merged 2 commits into from
May 2, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T358894#9762158

Notes

Adds presenting of feature announcement on app foreground.

Test Steps

  1. Fresh install app.
  2. Dismiss any initial modals that present on Explore
  3. When suggested edits card appears, background app.
  4. Foreground app
  5. Confirm feature announcement modal appears.
  6. Terminate app
  7. Relaunch app.
  8. Confirm you cannot trigger feature announcement again.

Screenshots/Videos

@tonisevener tonisevener changed the title Present announcement on app foreground Image Recommendations - Present announcement on app foreground May 1, 2024
@tonisevener tonisevener changed the title Image Recommendations - Present announcement on app foreground Image recommendations - Present announcement on app foreground May 1, 2024
@mazevedofs mazevedofs merged commit 2d4370a into main May 2, 2024
4 checks passed
mazevedofs
mazevedofs reviewed May 2, 2024
View reviewed changes
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to hit approve before merging, but it was reviewed and tested

@mazevedofs mazevedofs deleted the image-recs/announcement-on-foreground branch May 2, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazevedofs mazevedofs mazevedofs left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@tonisevener @mazevedofs