Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image recommendations - localization fixes #4835

Merged
merged 2 commits into from
May 2, 2024
Merged

Image recommendations - localization fixes #4835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1697ec0
Extract strings from Advanced Settings subdirectory
tonisevener May 2, 2024
c1b44ef
Add missing line from email prompt
tonisevener May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Wikipedia/Code/ExploreViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,7 +1283,8 @@ extension ExploreViewController: EditPreviewViewControllerDelegate {
let emailBodyLine2 = WMFLocalizedString("image-recommendations-email-second-line", value: "- [Describe specific problem]", comment: "Text for Image recommendations pre-filled issue report email. This text is intended to be replaced by the user with a description of the problem they are encountering")
let emailBodyLine3 = WMFLocalizedString("image-recommendations-email-third-line", value: "The behavior I would like to see is:", comment: "Text for Image recommendations pre-filled issue report email")
let emailBodyLine4 = WMFLocalizedString("image-recommendations-email-fourth-line", value: "- [Describe proposed solution]", comment: "Text for Image recommendations pre-filled issue report email. This text is intended to be replaced by the user with a description of a user suggested solution")
let emailBody = "\(emailBodyLine1)\n\n\(emailBodyLine2)\n\n\(emailBodyLine3)\n\n\(emailBodyLine4)"
let emailBodyLine5 = WMFLocalizedString("image-recommendations-email-fifth-line", value: "[Screenshots or Links]", comment: "Text for Image recommendations pre-filled issue report email. This text is intended to be replaced by the user with a screenshot or link.")
let emailBody = "\(emailBodyLine1)\n\n\(emailBodyLine2)\n\n\(emailBodyLine3)\n\n\(emailBodyLine4)\n\n\(emailBodyLine5)"
let mailto = "mailto:\(emailAddress)?subject=\(emailSubject)&body=\(emailBody)".addingPercentEncoding(withAllowedCharacters: .urlQueryAllowed)

guard let encodedMailto = mailto, let mailtoURL = URL(string: encodedMailto), UIApplication.shared.canOpenURL(mailtoURL) else {
Expand Down
6 changes: 6 additions & 0 deletions Wikipedia/Localizations/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
"action-unsaved-accessibility-notification" = "Article unsaved";
"action-update" = "Update";
"add-articles-to-reading-list" = "Add {{PLURAL:$1|$1 article|$1 articles}} to reading list";
"advanced-settings-title" = "Advanced settings";
"announcements-dismiss" = "Dismiss";
"app-store-keywords" = "Wikipedia, reference, wiki, encyclopedia, info, knowledge, research, information, explore, learn";
"app-store-release-notes" = "Fully customizable and easier to read Explore feed. Localization, performance improvements and bug fixes.";
Expand Down Expand Up @@ -581,6 +582,7 @@
"image-rec-tooltip-3-body" = "Decide if the image helps readers understand this topic better.";
"image-rec-tooltip-3-title" = "Decide";
"image-rec-view-article" = "View article";
"image-recommendations-email-fifth-line" = "[Screenshots or Links]";
"image-recommendations-email-first-line" = "I’ve encountered a problem with the Add an Image Suggested Edits Feature:";
"image-recommendations-email-fourth-line" = "- [Describe proposed solution]";
"image-recommendations-email-second-line" = "- [Describe specific problem]";
Expand Down Expand Up @@ -617,12 +619,16 @@
"insert-media-image-preview-select-image-action-title" = "Select image";
"insert-media-image-size-setting-custom" = "Custom";
"insert-media-image-size-setting-default" = "Default";
"insert-media-image-size-settings-measure-height" = "Height";
"insert-media-image-size-settings-measure-width" = "Width";
"insert-media-image-size-settings-px-unit-name" = "px";
"insert-media-image-size-settings-title" = "Image size";
"insert-media-image-text-wrapping-setting" = "Wrap text around image";
"insert-media-image-type-setting-basic" = "Basic";
"insert-media-image-type-setting-frame" = "Frame";
"insert-media-image-type-setting-frameless" = "Frameless";
"insert-media-image-type-setting-thumbnail" = "Thumbnail";
"insert-media-image-type-settings-footer-title" = "You can set how the media item appears on the page. This should be the thumbnail format to be consistent with other pages in almost all cases.";
"insert-media-image-type-settings-title" = "Image type";
"insert-media-media-settings-title" = "Media settings";
"insert-media-title" = "Insert media";
Expand Down
6 changes: 6 additions & 0 deletions Wikipedia/Localizations/qqq.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
"action-unsaved-accessibility-notification" = "Notification spoken after user removes an article from Saved articles.";
"action-update" = "Title of the update action.";
"add-articles-to-reading-list" = "Title for the view in charge of adding articles to a reading list - $1 is replaced with the number of articles to add";
"advanced-settings-title" = "Title for advanced settings screen";
"announcements-dismiss" = "Button text indicating a user wants to dismiss an announcement {{Identical|No thanks}}";
"app-store-keywords" = "Short list of keywords describing the app for the app store. It is required that these are individual words, not phrases, and are comma separated.";
"app-store-release-notes" = "Short summary of what is new in this version of the app for the app store";
Expand Down Expand Up @@ -581,6 +582,7 @@
"image-rec-tooltip-3-body" = "Body of second tooltip displayed when landing on image recommendations feature for the first time.";
"image-rec-tooltip-3-title" = "Title of second tooltip displayed when landing on image recommendations feature for the first time.";
"image-rec-view-article" = "Button from an image recommendation article summary. Tapping the button displays the full article.";
"image-recommendations-email-fifth-line" = "Text for Image recommendations pre-filled issue report email. This text is intended to be replaced by the user with a screenshot or link.";
"image-recommendations-email-first-line" = "Text for Image recommendations pre-filled issue report email";
"image-recommendations-email-fourth-line" = "Text for Image recommendations pre-filled issue report email. This text is intended to be replaced by the user with a description of a user suggested solution";
"image-recommendations-email-second-line" = "Text for Image recommendations pre-filled issue report email. This text is intended to be replaced by the user with a description of the problem they are encountering";
Expand Down Expand Up @@ -617,12 +619,16 @@
"insert-media-image-preview-select-image-action-title" = "Title for preview action that results in image selection";
"insert-media-image-size-setting-custom" = "Title for image size setting that sizes image using custom size";
"insert-media-image-size-setting-default" = "Title for image size setting that sizes image using default size";
"insert-media-image-size-settings-measure-height" = "Display title for the measurement of image from top to base";
"insert-media-image-size-settings-measure-width" = "Display title for the measurement of image from side to side";
"insert-media-image-size-settings-px-unit-name" = "Image size unit name, abbreviation for 'pixels'";
"insert-media-image-size-settings-title" = "Display ritle for image size setting";
"insert-media-image-text-wrapping-setting" = "Title for image setting that wraps text around image";
"insert-media-image-type-setting-basic" = "Title for image type setting that formats image as basic";
"insert-media-image-type-setting-frame" = "Title for image type setting that formats image as framed";
"insert-media-image-type-setting-frameless" = "Title for image type setting that formats image as frameless";
"insert-media-image-type-setting-thumbnail" = "Title for image type setting that formats image as thumbnail";
"insert-media-image-type-settings-footer-title" = "Footer for";
"insert-media-image-type-settings-title" = "Display ritle for image type setting";
"insert-media-media-settings-title" = "Title for media settings view";
"insert-media-title" = "Title for the view in charge of inserting media into an article";
Expand Down
Binary file modified Wikipedia/iOS Native Localizations/en.lproj/Localizable.strings
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion scripts/localization_extract
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# Extracts localizations from source code

cd "$1"
xcrun extractLocStrings -s WMFLocalizedString -o Wikipedia/iOS\ Native\ Localizations/en.lproj/ Wikipedia/Code/*.m Wikipedia/Code/*.swift WMF\ Framework/*.m WMF\ Framework/*.swift WMF\ Framework/Remote\ Notifications/*.swift WMF\ Framework/Remote\ Notifications/*/*.swift ContinueReadingWidget/*.swift Widgets/Widgets/*.swift NotificationServiceExtension/*.swift
xcrun extractLocStrings -s WMFLocalizedString -o Wikipedia/iOS\ Native\ Localizations/en.lproj/ Wikipedia/Code/*.m Wikipedia/Code/*.swift Wikipedia/Code/Advanced\ Settings/*.swift WMF\ Framework/*.m WMF\ Framework/*.swift WMF\ Framework/Remote\ Notifications/*.swift WMF\ Framework/Remote\ Notifications/*/*.swift ContinueReadingWidget/*.swift Widgets/Widgets/*.swift NotificationServiceExtension/*.swift