Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native Recommendations - add translations #4838

Merged
merged 4 commits into from
May 2, 2024
Merged

Native Recommendations - add translations #4838

merged 4 commits into from
May 2, 2024

Conversation

mazevedofs
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T363925

Notes

Adds a localized string that didn't come through Translate Wiki in the latest PR. Spanish came through; I just edited the dash.

Test Steps

  1. On Image recs, go to "Problem with feature" in the overflow menu in Chinese, Portuguese, Spanish or French . Confirm "[Screenshots or Links]" is added at the end in the correct language.

@tonisevener tonisevener self-assigned this May 2, 2024
@tonisevener tonisevener removed their assignment May 2, 2024
tonisevener
tonisevener approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added some commits fixing some translation issues I found from my sloppy copying 😅.

@tonisevener tonisevener merged commit c7f6032 into main May 2, 2024
4 checks passed
@tonisevener tonisevener deleted the image-recs-add-translations branch May 2, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonisevener tonisevener tonisevener approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@mazevedofs @tonisevener