Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove underscores and html strings from add image details view #4839

Merged
merged 2 commits into from
May 3, 2024

Conversation

tonisevener
Copy link
Collaborator

@tonisevener tonisevener commented May 2, 2024

Phabricator: https://phabricator.wikimedia.org/T363944

Notes

Removes underscores and html tags from image information before showing "Add image details" view. Also ensure the image description is displayed from the editor flow.

Test Steps

  1. Go to "Add image details" view in recommendations flow.
  2. Confirm image title and description does not show underscores or html tags.
  3. From editor flow, tap image wizard. Tap through until you reach the "Media settings" view. Confirm image description shows beneath image url.

@mazevedofs mazevedofs merged commit 4b16076 into main May 3, 2024
4 checks passed
@mazevedofs mazevedofs deleted the image-recs/image-details-markdown branch May 3, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants