Image recommendations - hide settings toggle #4841
Conversation
…o image-recs-settings-toggle-fix
| var editCount: Int { | ||
| var count: Int = 0 | ||
| if let language = self.dataStore?.languageLinkController.appLanguage?.siteURL { | ||
| self.dataStore?.authenticationManager.getLoggedInUser(for: language, completion: { result in |
There was a problem hiding this comment.
Just note that this is an async call, so if it needs to make a network request this count would return 0 while it's fetching. I think because we have good caching within getLoggedInUser, it rarely needs to make a call here. Very rarely I could reproduce some weirdness where if I slowed down the connection speed, launched the app, then went straight to the Explore feed settings the toggle would be missing. But returning a little bit later (once the user was fetched) allowed it to appear again.
Not a blocker IMO but something to remember if we hear complaints.
There was a problem hiding this comment.
Good point, should we create a ticket to improve this? Since we're doing some tech debt work soon?
There was a problem hiding this comment.
Sounds good! Created a task here - https://phabricator.wikimedia.org/T364133
Phabricator: https://phabricator.wikimedia.org/T364038
Notes
Test Steps